Flummi/amxmodx
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for loop index out of bounds error (#966)

Browse Source 
Fixes an index out of bounds error when refreshMenus() and subsequently findAdminsWithMenu() is called when there is 32 players in the server. Indexing the playersList array in the for loop condition causes it to try to index with a value of 32 on the very last condition check which is not valid for this array.
This commit is contained in:
Fysiks 2021-06-19 03:36:56 -05:00 committed by GitHub
parent 3c1856f7af
commit 7fef58c374
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/cstrike/restmenu.sma
View File

@ -495,8 +495,10 @@ findAdminsWithMenu(playersList[MAX_PLAYERS], &playersCount, const commandLevel =
get_players(playersList, playersCount, "ch"); get_players(playersList, playersCount, "ch");
for (new i = 0; i < playersCount, (player = playersList[i]); ++i) for (new i = 0; i < playersCount; ++i)
{ {
player = playersList[i]
if (player_menu_info(player, menu, newmenu) && newmenu != -1 && newmenu == MenuHandle[player]) if (player_menu_info(player, menu, newmenu) && newmenu != -1 && newmenu == MenuHandle[player])
{ {
if (commandLevel == -1 || access(player, commandLevel)) // extra safety if (commandLevel == -1 || access(player, commandLevel)) // extra safety
@ -519,8 +521,10 @@ refreshMenus(const commandLevel = 0, const bool:displaySaveMessage = false)
return; return;
} }
for (new i = 0, player; i < playersCount, (player = playersList[i]); ++i) for (new i = 0, player; i < playersCount; ++i)
{ {
player = playersList[i]
MenuHandle[player] = displayMenu(player, MenuPosition[player]); MenuHandle[player] = displayMenu(player, MenuPosition[player]);
if (displaySaveMessage) if (displaySaveMessage)