GCC Wallification

dlls/sqlite/Makefile

@@ -31,25 +31,29 @@ C_OBJECTS = $(SQL)/attach.c $(SQL)/auth.c $(SQL)/btree.c $(SQL)/build.c \
 	$(SQL)/prepare.c $(SQL)/expr.c $(SQL)/callback.c $(SQL)/alter.c \
 	$(SQL)/vdbefifo.c $(SQL)/complete.c $(SQL)/analyze.c
 
+CFLAGS = -Wall -Werror
+CPPFLAGS = -Wall -Wno-non-virtual-dtor -Werror
+
 LINK = -static-libgcc -lpthread /lib/libgcc_eh.a /lib/libstdc++.a
 
 INCLUDE = -I. -I$(HLSDK) -I$(HLSDK)/dlls -I$(HLSDK)/engine -I$(HLSDK)/game_shared -I$(HLSDK)/game_shared \
 	-I$(MM_ROOT) -I$(HLSDK)/common -I$(SQL) -I./sqlitepp -I./sdk -I./thread
 
+ifeq "$(DEBUG)" "true"
+	BIN_DIR = Debug
+	CFLAGS += $(DEBUG_FLAGS)
+	CPPFLAGS += $(DEBUG_FLAGS)
+else
+	BIN_DIR = Release
+	CFLAGS += $(OPT_FLAGS)
+	CPPFLAGS += $(OPT_FLAGS)
+endif
+
 GCC_VERSION := $(shell $(CPP) -dumpversion >&1 | cut -b1)
 
 ifeq "$(GCC_VERSION)" "4"
-        OPT_FLAGS += -fvisibility=hidden -fvisibility-inlines-hidden
-endif
-
-ifeq "$(DEBUG)" "true"
-	BIN_DIR = Debug
-	CFLAGS = $(DEBUG_FLAGS)
-	CPPFLAGS = $(DEBUG_FLAGS)
-else
-	BIN_DIR = Release
-	CFLAGS = $(OPT_FLAGS)
-	CPPFLAGS = $(OPT_FLAGS)
+	CFLAGS += -fvisibility=hidden
+	CPPFLAGS += -fvisibility=hidden -fvisibility-inlines-hidden
 endif
 
 CPPFLAGS += -DNDEBUG -fPIC -Wno-deprecated -fno-exceptions -DHAVE_STDINT_H -fno-rtti

dlls/sqlite/sqlite-source/btree.c

@@ -5392,9 +5392,9 @@ int sqlite3BtreeDelete(BtCursor *pCur){
     */
     BtCursor leafCur;
     unsigned char *pNext;
-    int szNext;  /* The compiler warning is wrong: szNext is always 
-                 ** initialized before use.  Adding an extra initialization
-                 ** to silence the compiler slows down the code. */
+    int szNext = 0;  /* The compiler warning is wrong: szNext is always 
+                      ** initialized before use.  Adding an extra initialization
+                      ** to silence the compiler slows down the code. */
     int notUsed;
     unsigned char *tempCell = 0;
     assert( !pPage->leafData );

dlls/sqlite/sqlite-source/printf.c

@@ -230,7 +230,7 @@ static int vxprintf(
   char buf[etBUFSIZE];       /* Conversion buffer */
   char prefix;               /* Prefix character.  "+" or "-" or " " or '\0'. */
   etByte errorflag = 0;      /* True if an error is encountered */
-  etByte xtype;              /* Conversion paradigm */
+  etByte xtype = 0;          /* Conversion paradigm */
   char *zExtra;              /* Extra memory used for etTCLESCAPE conversions */
   static const char spaces[] =
    "                                                                         ";

dlls/sqlite/sqlite-source/select.c

@@ -688,7 +688,7 @@ static void generateSortTail(
   int cont = sqlite3VdbeMakeLabel(v);
   int addr;
   int iTab;
-  int pseudoTab;
+  int pseudoTab = 0;
   ExprList *pOrderBy = p->pOrderBy;
 
   iTab = pOrderBy->iECursor;

dlls/sqlite/sqlitepp/ISQLDriver.h

@@ -7,6 +7,8 @@ namespace SourceMod
 {
 	class IResultRow
 	{
+	public:
+		virtual ~IResultRow() { };
 	public:
 		/**
 		 * This will return NULL if the entry is NULL.
@@ -26,6 +28,8 @@ namespace SourceMod
 
 	class IResultSet
 	{
+	public:
+		virtual ~IResultSet() { };
 	public:
 		//free the handle if necessary (see IQuery).
 		virtual void FreeHandle() =0;
@@ -65,6 +69,8 @@ namespace SourceMod
 
 	class IQuery
 	{
+	public:
+		virtual ~IQuery() { };
 	public:
 		//you must free the handle when done
 		virtual void FreeHandle() =0;
@@ -94,6 +100,8 @@ namespace SourceMod
 
 	class IDatabase
 	{
+	public:
+		virtual ~IDatabase() { };
 	public:
 		/** 
 		 * Closes the database and frees the handle.
@@ -130,6 +138,8 @@ namespace SourceMod
 
 	class ISQLDriver
 	{
+	public:
+		virtual ~ISQLDriver() { };
 	public:
 		virtual IDatabase *Connect(DatabaseInfo *info, int *errcode, char *error, size_t maxlength) =0;
 		virtual const char *NameString() =0;

dlls/sqlite/thread/IThreader.h

@@ -92,6 +92,8 @@ namespace SourceMod
 	 */
 	class IThread
 	{
+	public:
+		virtual ~IThread() { };
 	public:
 		//Called when the thread runs
 		virtual void RunThread(IThreadHandle *pHandle) =0;
@@ -107,6 +109,8 @@ namespace SourceMod
 	 */
 	class IThreadCreator
 	{
+	public:
+		virtual ~IThreadCreator() { };
 	public:
 		//Makes a thread and cleans up the handle for you
 		virtual void MakeThread(IThread *pThread) =0;
@@ -147,6 +151,8 @@ namespace SourceMod
 
 	class IEventSignal
 	{
+	public:
+		virtual ~IEventSignal() { };
 	public:
 		/**
 		 * Waits for the signal.