Merge pull request #6 from Farkal/master

Transmit cookies on redirect
This commit is contained in:
jkhsjdhjs 2020-06-17 13:41:49 +02:00 committed by GitHub
commit 120ce5c6c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,9 +1,12 @@
import _fetch from "node-fetch"; import _fetch from "node-fetch";
import CookieJar from "./cookie-jar.mjs"; import CookieJar from "./cookie-jar.mjs";
import Cookie from "./cookie.mjs"; import Cookie from "./cookie.mjs";
import {paramError, CookieParseError} from "./errors.mjs" import {paramError, CookieParseError} from "./errors.mjs";
const redirectStatus = new Set([301, 302, 303, 307, 308]);
async function fetch(cookieJars, url, options) { async function fetch(cookieJars, url, options) {
let cookies = ""; let cookies = "";
const addValidFromJars = jars => { const addValidFromJars = jars => {
// since multiple cookie jars can be passed, filter duplicates by using a set of cookie names // since multiple cookie jars can be passed, filter duplicates by using a set of cookie names
@ -32,6 +35,12 @@ async function fetch(cookieJars, url, options) {
options.headers = {}; options.headers = {};
options.headers.cookie = cookies.slice(0, -2); options.headers.cookie = cookies.slice(0, -2);
} }
const wantFollow = !options || !options.redirect || options.redirect === 'follow';
if(wantFollow) {
if (!options) options = {};
options.redirect = 'manual';
}
const result = await _fetch(url, options); const result = await _fetch(url, options);
// I cannot use headers.get() here because it joins the cookies to a string // I cannot use headers.get() here because it joins the cookies to a string
cookies = result.headers[Object.getOwnPropertySymbols(result.headers)[0]]["set-cookie"]; cookies = result.headers[Object.getOwnPropertySymbols(result.headers)[0]]["set-cookie"];
@ -44,6 +53,11 @@ async function fetch(cookieJars, url, options) {
else if(cookieJars instanceof CookieJar && cookieJars.flags.includes("w")) else if(cookieJars instanceof CookieJar && cookieJars.flags.includes("w"))
cookies.forEach(c => cookieJars.addCookie(c, url)); cookies.forEach(c => cookieJars.addCookie(c, url));
} }
if(wantFollow && redirectStatus.has(result.status)) {
const location = result.headers.get('Location');
options.redirect = 'follow';
return fetch(cookieJars, location, options);
}
return result; return result;
} }