add eslint + prettier

reformat code with prettier
This commit is contained in:
2020-06-17 15:04:32 +02:00
parent 120ce5c6c6
commit c4b04ed3dc
13 changed files with 1889 additions and 445 deletions

View File

@ -4,282 +4,412 @@ import {CookieParseError} from "../src/errors.mjs";
export default Test => [
new Test("new Cookie() / cookie parser", () => {
const inputs = [
[ // type error
[
// type error
123,
""
],
[ // type error
[
// type error
"id=a3fWa",
123
],
[ // type error invalid url
[
// type error invalid url
"id=a3fWa",
""
],
[ // type error invalid url
[
// type error invalid url
"id=a3fWa",
"github.com"
],
// TODO: fix this test case, parser shouldn't allow it. it is currently ignored
[ // type error invalid url
"id=a3fWa",
[
// type error invalid url
"id=a3fWa",
"https:abc/abs"
],
[ // cookie parse error invalid cookie name
[
// cookie parse error invalid cookie name
"",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:28: GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Onv 2015 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 20151 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 32 Oct 2015 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 2015 25:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:61:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:28:00 UTC; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:28:00 GMT+2; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=San, 21 Onv 2015 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Expires=Wed, 31 Dec 1969 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid value for expires
[
// cookie parse error invalid value for expires
"id=a3fWa; Max-Age=121252a; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid key secur
[
// cookie parse error invalid key secur
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:28:00 GMT; Secur; HttpOnly",
"https://github.com"
],
[ // cookie parse error invalid key HttpOly with value 2
[
// cookie parse error invalid key HttpOly with value 2
"id=a3fWa; Expires=Wed, 21 Oct 2015 07:28:00 GMT; Secure; HttpOly=2",
"https://github.com"
],
[ // cookie parse error not set via https
[
// cookie parse error not set via https
"__Secure-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly",
"http://github.com"
],
[ // cookie parse error secure not set
[
// cookie parse error secure not set
"__Secure-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; HttpOnly",
"https://github.com"
],
[ // cookie parse error secure not set
[
// cookie parse error secure not set
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; HttpOnly; Path=/",
"https://github.com"
],
[ // cookie parse error not set via https
[
// cookie parse error not set via https
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; Path=/",
"http://github.com"
],
[ // cookie parse error domain is set
[
// cookie parse error domain is set
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; Domain=github.com; Path=/",
"https://github.com"
],
[ // cookie parse error path is not set
[
// cookie parse error path is not set
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // cookie parse error path is not equal to /
[
// cookie parse error path is not equal to /
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; Path=/lel/",
"https://github.com"
],
[ // cookie parse error domain is not a subdomain
[
// cookie parse error domain is not a subdomain
"id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Domain=github.com",
"https://gist.github.com"
],
[ // cookie parse error domain is not a subdomain
[
// cookie parse error domain is not a subdomain
"id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Domain=npmjs.com",
"https://gist.github.com"
],
[ // success
[
// success
"__Secure-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly",
"https://github.com"
],
[ // success
[
// success
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; Path=/",
"https://github.com"
],
[ // success
[
// success
"__Host-id=a3fWa; Expires=Wed, 21 Nov 2099 20:28:33 GMT; Secure; HttpOnly; Path=/",
"https://github.com"
],
[ // success
[
// success
"id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; Path=/lul/; Domain=.usercontent.github.com",
"https://github.com"
],
[ // success
[
// success
"id=a3fWa; Expires=Wed, 21 Nov 2015 07:28:00 GMT; Secure; HttpOnly; SameSite=Strict; Path=/lul/; Domain=usercontent.github.com",
"https://github.com"
],
[ // success max-age takes precendence over expires
[
// success max-age takes precendence over expires
"id=a3fWa; Expires=Thu, 01 Jan 1970 00:00:00 GMT; Max-Age=1000",
"https://github.com"
],
[ // success max-age takes precendence over expires
"id=\"a3fWa\"; Max-Age=1000; Expires=Thu, 01 Jan 1970 00:00:00 GMT",
[
// success max-age takes precendence over expires
'id="a3fWa"; Max-Age=1000; Expires=Thu, 01 Jan 1970 00:00:00 GMT',
"https://github.com"
],
]
];
const catchErrorTest = (input, catchFnc) => {
try {
new Cookie(...input);
return false;
}
catch(error) {
} catch (error) {
return catchFnc(error);
}
};
const catchErrorTypeMessageTest = (input, type, message) => catchErrorTest(input, e => e instanceof type && e.message === message);
const catchErrorTypeMessageTest = (input, type, message) =>
catchErrorTest(
input,
e => e instanceof type && e.message === message
);
const compareCookieProps = (input, expiryFnc, properties) => {
const cookie = new Cookie(...input);
return Object.entries(properties).every(([prop, value]) => cookie[prop] === value)
&& expiryFnc(cookie.expiry);
return (
Object.entries(properties).every(
([prop, value]) => cookie[prop] === value
) && expiryFnc(cookie.expiry)
);
};
return inputs.slice(0, 3).every(input => catchErrorTest(input, e => e instanceof TypeError))
return (
inputs
.slice(0, 3)
.every(input =>
catchErrorTest(input, e => e instanceof TypeError)
) &&
// cookies[4] is the test case that is ignored for now
// cookies[4] is the test case that is ignored for now
&& catchErrorTypeMessageTest(inputs[5], CookieParseError, "Invalid cookie name \"\"!")
&& catchErrorTypeMessageTest(inputs[6], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 2015 07:28: GMT\"!")
&& catchErrorTypeMessageTest(inputs[7], CookieParseError, "Invalid value for Expires \"Wed, 21 Onv 2015 07:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[8], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 20151 07:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[9], CookieParseError, "Invalid value for Expires \"Wed, 32 Oct 2015 07:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[10], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 2015 25:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[11], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 2015 07:61:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[12], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 2015 07:28:00 UTC\"!")
&& catchErrorTypeMessageTest(inputs[13], CookieParseError, "Invalid value for Expires \"Wed, 21 Oct 2015 07:28:00 GMT+2\"!")
&& catchErrorTypeMessageTest(inputs[14], CookieParseError, "Invalid value for Expires \"San, 21 Onv 2015 07:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[15], CookieParseError, "Invalid value for Expires \"Wed, 31 Dec 1969 07:28:00 GMT\"!")
&& catchErrorTypeMessageTest(inputs[16], CookieParseError, "Invalid value for Max-Age \"121252a\"!")
&& catchErrorTypeMessageTest(inputs[17], CookieParseError, "Invalid key \"secur\" specified!")
&& catchErrorTypeMessageTest(inputs[18], CookieParseError, "Invalid key \"httpoly\" with value \"2\" specified!")
&& inputs.slice(19, 21).every(input => catchErrorTypeMessageTest(input, CookieParseError, "Cookie has \"__Secure-\" prefix but \"Secure\" isn't set or the cookie is not set via https!"))
&& inputs.slice(21, 26).every(input => catchErrorTypeMessageTest(input, CookieParseError, "Cookie has \"__Host-\" prefix but \"Secure\" isn't set, the cookie is not set via https, \"Domain\" is set or \"Path\" is not equal to \"/\"!"))
&& catchErrorTypeMessageTest(inputs[26], CookieParseError, "Invalid value for Domain \"github.com\": cookie was received from \"gist.github.com\"!")
&& catchErrorTypeMessageTest(inputs[27], CookieParseError, "Invalid value for Domain \"npmjs.com\": cookie was received from \"gist.github.com\"!")
&& compareCookieProps(
inputs[28],
exp => exp.getTime() === new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "__Secure-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
)
&& compareCookieProps(
inputs[29],
exp => exp.getTime() === new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "__Host-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
)
&& compareCookieProps(
inputs[30],
exp => exp.getTime() === new Date("Wed, 21 Nov 2099 20:28:33 GMT").getTime(),
{
name: "__Host-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
)
&& compareCookieProps(
inputs[31],
exp => exp.getTime() === new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: true,
domain: "usercontent.github.com",
subdomains: true,
path: "/lul/"
}
)
&& compareCookieProps(
inputs[32],
exp => exp.getTime() === new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: true,
domain: "usercontent.github.com",
subdomains: true,
path: "/lul/"
}
)
&& compareCookieProps(
inputs[33],
exp => exp.getTime() > new Date("Thu, 01 Jan 1970 00:00:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: false,
domain: "github.com",
subdomains: false,
path: "/"
}
)
&& compareCookieProps(
inputs[34],
exp => exp.getTime() > new Date("Thu, 01 Jan 1970 00:00:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: false,
domain: "github.com",
subdomains: false,
path: "/"
}
catchErrorTypeMessageTest(
inputs[5],
CookieParseError,
'Invalid cookie name ""!'
) &&
catchErrorTypeMessageTest(
inputs[6],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 2015 07:28: GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[7],
CookieParseError,
'Invalid value for Expires "Wed, 21 Onv 2015 07:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[8],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 20151 07:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[9],
CookieParseError,
'Invalid value for Expires "Wed, 32 Oct 2015 07:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[10],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 2015 25:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[11],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 2015 07:61:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[12],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 2015 07:28:00 UTC"!'
) &&
catchErrorTypeMessageTest(
inputs[13],
CookieParseError,
'Invalid value for Expires "Wed, 21 Oct 2015 07:28:00 GMT+2"!'
) &&
catchErrorTypeMessageTest(
inputs[14],
CookieParseError,
'Invalid value for Expires "San, 21 Onv 2015 07:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[15],
CookieParseError,
'Invalid value for Expires "Wed, 31 Dec 1969 07:28:00 GMT"!'
) &&
catchErrorTypeMessageTest(
inputs[16],
CookieParseError,
'Invalid value for Max-Age "121252a"!'
) &&
catchErrorTypeMessageTest(
inputs[17],
CookieParseError,
'Invalid key "secur" specified!'
) &&
catchErrorTypeMessageTest(
inputs[18],
CookieParseError,
'Invalid key "httpoly" with value "2" specified!'
) &&
inputs
.slice(19, 21)
.every(input =>
catchErrorTypeMessageTest(
input,
CookieParseError,
'Cookie has "__Secure-" prefix but "Secure" isn\'t set or the cookie is not set via https!'
)
) &&
inputs
.slice(21, 26)
.every(input =>
catchErrorTypeMessageTest(
input,
CookieParseError,
'Cookie has "__Host-" prefix but "Secure" isn\'t set, the cookie is not set via https, "Domain" is set or "Path" is not equal to "/"!'
)
) &&
catchErrorTypeMessageTest(
inputs[26],
CookieParseError,
'Invalid value for Domain "github.com": cookie was received from "gist.github.com"!'
) &&
catchErrorTypeMessageTest(
inputs[27],
CookieParseError,
'Invalid value for Domain "npmjs.com": cookie was received from "gist.github.com"!'
) &&
compareCookieProps(
inputs[28],
exp =>
exp.getTime() ===
new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "__Secure-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
) &&
compareCookieProps(
inputs[29],
exp =>
exp.getTime() ===
new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "__Host-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
) &&
compareCookieProps(
inputs[30],
exp =>
exp.getTime() ===
new Date("Wed, 21 Nov 2099 20:28:33 GMT").getTime(),
{
name: "__Host-id",
value: "a3fWa",
secure: true,
domain: "github.com",
subdomains: false,
path: "/"
}
) &&
compareCookieProps(
inputs[31],
exp =>
exp.getTime() ===
new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: true,
domain: "usercontent.github.com",
subdomains: true,
path: "/lul/"
}
) &&
compareCookieProps(
inputs[32],
exp =>
exp.getTime() ===
new Date("Wed, 21 Nov 2015 07:28:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: true,
domain: "usercontent.github.com",
subdomains: true,
path: "/lul/"
}
) &&
compareCookieProps(
inputs[33],
exp =>
exp.getTime() >
new Date("Thu, 01 Jan 1970 00:00:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: false,
domain: "github.com",
subdomains: false,
path: "/"
}
) &&
compareCookieProps(
inputs[34],
exp =>
exp.getTime() >
new Date("Thu, 01 Jan 1970 00:00:00 GMT").getTime(),
{
name: "id",
value: "a3fWa",
secure: false,
domain: "github.com",
subdomains: false,
path: "/"
}
)
);
}),
new Test("static Cookie.fromObject()", () => {
@ -307,24 +437,34 @@ export default Test => [
const cookies = inputs.map(i => Cookie.fromObject(i));
return cookies[0].name === "testname"
&& cookies[0].value === "somevalue"
&& cookies[0].domain === "github.com"
&& cookies[0].path === "/"
&& cookies[0].expiry.getTime() === new Date(inputs[0].expiry).getTime()
&& cookies[0].secure === false
&& cookies[0].subdomains === false
&& cookies[1].name === "testname"
&& cookies[1].value === "lul"
&& cookies[1].domain === "somedomain.tld"
&& cookies[1].path === "/lel/"
&& cookies[1].expiry.getTime() === date.getTime()
&& cookies[1].secure === true
&& cookies[1].subdomains === true;
return (
cookies[0].name === "testname" &&
cookies[0].value === "somevalue" &&
cookies[0].domain === "github.com" &&
cookies[0].path === "/" &&
cookies[0].expiry.getTime() ===
new Date(inputs[0].expiry).getTime() &&
cookies[0].secure === false &&
cookies[0].subdomains === false &&
cookies[1].name === "testname" &&
cookies[1].value === "lul" &&
cookies[1].domain === "somedomain.tld" &&
cookies[1].path === "/lel/" &&
cookies[1].expiry.getTime() === date.getTime() &&
cookies[1].secure === true &&
cookies[1].subdomains === true
);
}),
new Test("Cookie.serialize()", () => {
return new Cookie("abc=def; Expires=Wed, 20 Oct 2018 08:08:08 GMT; Path=/", "https://somedomain.tld").serialize() === "abc=def"
&& new Cookie("jkhsd231=ajkshdgi", "https://somedomain.tld").serialize() === "jkhsd231=ajkshdgi";
return (
new Cookie(
"abc=def; Expires=Wed, 20 Oct 2018 08:08:08 GMT; Path=/",
"https://somedomain.tld"
).serialize() === "abc=def" &&
new Cookie(
"jkhsd231=ajkshdgi",
"https://somedomain.tld"
).serialize() === "jkhsd231=ajkshdgi"
);
})
];

View File

@ -8,20 +8,32 @@ export default Test => [
const validTypes = ["lol", "lel", "lul", "lal"];
const errors = [
paramError(position, paramName, functionName, validTypes[0]),
paramError(position, paramName, functionName, validTypes.slice(0, 2)),
paramError(
position,
paramName,
functionName,
validTypes.slice(0, 2)
),
paramError(position, paramName, functionName, validTypes)
];
return errors.every(e => e instanceof TypeError)
&& errors.every(e => e.name === "TypeError")
&& errors[0].message === "something parameter \"some_param\" passed to \"some_func\" is not of type \"lol\"!"
&& errors[1].message === "something parameter \"some_param\" passed to \"some_func\" is not of type \"lol\" or \"lel\"!"
&& errors[2].message === "something parameter \"some_param\" passed to \"some_func\" is not of type \"lol\", \"lel\", \"lul\" or \"lal\"!";
return (
errors.every(e => e instanceof TypeError) &&
errors.every(e => e.name === "TypeError") &&
errors[0].message ===
'something parameter "some_param" passed to "some_func" is not of type "lol"!' &&
errors[1].message ===
'something parameter "some_param" passed to "some_func" is not of type "lol" or "lel"!' &&
errors[2].message ===
'something parameter "some_param" passed to "some_func" is not of type "lol", "lel", "lul" or "lal"!'
);
}),
new Test("class CookieParseError", () => {
const message = "this is a test error";
const error = new CookieParseError(message);
return error instanceof CookieParseError
&& error.name === "CookieParseError"
&& error.message === message;
return (
error instanceof CookieParseError &&
error.name === "CookieParseError" &&
error.message === message
);
})
];

View File

@ -3,43 +3,51 @@ import errors from "./errors.mjs";
class Test {
constructor(name, fnc) {
this.name = name
this.fnc = fnc
this.name = name;
this.fnc = fnc;
}
async runTest() {
return this.fnc();
}
}
const tests = [
cookie,
errors
].flatMap(t => t(Test));
const tests = [cookie, errors].flatMap(t => t(Test));
(async () => {
console.log("running tests...");
const testResults = await Promise.all(tests.map(async t => {
try {
t.result = await t.runTest();
if(t.result !== !!t.result) {
const testResults = await Promise.all(
tests.map(async t => {
try {
t.result = await t.runTest();
if (t.result !== !!t.result) {
t.result = false;
console.error("test did not return a boolean: " + t.name);
}
} catch (error) {
console.error(
"uncaught error in test: " + t.name + "\n",
error
);
t.result = false;
console.error("test did not return a boolean: " + t.name);
}
}
catch(error) {
console.error("uncaught error in test: " + t.name + "\n", error);
t.result = false;
}
return t;
}));
return t;
})
);
testResults.forEach(t => {
if(t.result)
console.info(" " + t.name);
else
console.warn("✘ " + t.name);
if (t.result) console.info("✔ " + t.name);
else console.warn(" " + t.name);
});
const succeededTests = testResults.map(t => t.result).reduce((a, b) => a + b);
const succeededTests = testResults
.map(t => t.result)
.reduce((a, b) => a + b);
const success = succeededTests === testResults.length;
(success ? console.info : console.warn)((success ? "✔" : "✘") + " " + succeededTests + "/" + testResults.length + " tests successful");
(success ? console.info : console.warn)(
(success ? "✔" : "✘") +
" " +
succeededTests +
"/" +
testResults.length +
" tests successful"
);
!success && process.exit(1);
})();