Fixes an index out of bounds error when refreshMenus() and subsequently findAdminsWithMenu() is called when there is 32 players in the server. Indexing the playersList array in the for loop condition causes it to try to index with a value of 32 on the very last condition check which is not valid for this array.
Revised by Norbee. @ ebateam.eu
He was just lazy to do a PR :P
# Conflicts:
# plugins/lang/admincmd.txt
# plugins/lang/adminhelp.txt
# plugins/lang/menufront.txt
* [admincmd.sma] Fix typo in isCommandArgSafe
'
* [admincmd.sma] Update amx_cvar command handler
- Fix exploiting of "mapchangecfgfile" cvar to execute potentially dangerous console commands
- Add newline delimiter check and restrict for ****cfgfile cvars values
* Restrict having ".." character sequence in amx_map command argument
Fixes exploit on Windows servers that allows executing potentially dangerous console commands
* Do not allow admins to change cvars with FCVAR_SPONLY flag when not in singleplayer via amx_cvar
1. Make amx_cvar command obey FCVAR_SPONLY flag.
2. Fix exploiting of amx_nextmap cvar value which is used in nextmap plugin.
* Restrict having ".." character sequence in amx_votemap command arguments
Fixes exploit on Windows servers that allows executing potentially dangerous console commands
* Fix typo
containi -> contain
* Fix newlines for TextMsg
* Fix newlines for SayText
* Adjust comments
* Replace hardcoded detination value with HUD_* constants
* Make sure only official mods can use format string
* Fix typos
* Split condition for readability
* CS only: Fix newlines in TextMsg and with print_center
* Fixes to read_args and read_argv* natives
* Fixed crash with read_argv* natives and commands sent with amxclient_cmd native
* Fixed read_args returning argv[0] instead of empty string when both amxclient_cmd's arguments were not specified
* Fix spaces
* Add AMXX_VERSION_LOCAL define
* Add new defines regarding version of AMX Mod X
Added new defines: AMXX_VERSION_MAJOR_NUM and AMXX_VERSION_MINOR_NUM
* Rename AMXX_VERSION_LOCAL define
Define AMXX_VERSION_LOCAL was renamed to AMXX_VERSION_LOCAL_REV_NUM
Recently, I got those below errors on logs:
```
String formatted incorrectly - parameter 12 (total 12)
L 04/29/2019 - 23:24:40: [AMXX] Displaying debug trace (plugin "miscstats.amxx", version "1.8.3-dev+5154")
L 04/29/2019 - 23:24:40: [AMXX] Run time error 25: parameter error
L 04/29/2019 - 23:24:40: [AMXX] [0] miscstats.sma::checkKills (line 922)
```
It just looks like `"RAMPAGE!!! %s^n%L %d %L (%d hs)"` misses last format rule, which should be `"%L"` pointing to `HS` lang key.
* Lack register_event() on event_enable/disable
Lack register_event() on enable_event and disable_event descriptions
* It shoud be m_iJoiningState not m_iJointState
It shoud be m_iJoiningState not m_iJointState
* Menu buttons stayed english in Plugin's cvar/command menus
That worked, but if there is any better solution to get it working feel free to edit :D
* Changed language parsing to %L
Just a small fix on json_parse return description. I'm sure it was supposed to be `Invalid_JSON` instead of `Invalid_JSONValue`.
Thank you, guys, that's one of my favorites features.
#554 (Revert "Fun: Make TraceLine a post forward") did not fully revert back TraceLine. RETURN_META(MRES_HANDLED); was added by #421 (Update Fun module) but still remains there.
