Fixes an index out of bounds error when refreshMenus() and subsequently findAdminsWithMenu() is called when there is 32 players in the server. Indexing the playersList array in the for loop condition causes it to try to index with a value of 32 on the very last condition check which is not valid for this array.
Revised by Norbee. @ ebateam.eu
He was just lazy to do a PR :P
# Conflicts:
# plugins/lang/admincmd.txt
# plugins/lang/adminhelp.txt
# plugins/lang/menufront.txt
* [admincmd.sma] Fix typo in isCommandArgSafe
'
* [admincmd.sma] Update amx_cvar command handler
- Fix exploiting of "mapchangecfgfile" cvar to execute potentially dangerous console commands
- Add newline delimiter check and restrict for ****cfgfile cvars values
* Restrict having ".." character sequence in amx_map command argument
Fixes exploit on Windows servers that allows executing potentially dangerous console commands
* Do not allow admins to change cvars with FCVAR_SPONLY flag when not in singleplayer via amx_cvar
1. Make amx_cvar command obey FCVAR_SPONLY flag.
2. Fix exploiting of amx_nextmap cvar value which is used in nextmap plugin.
* Restrict having ".." character sequence in amx_votemap command arguments
Fixes exploit on Windows servers that allows executing potentially dangerous console commands
* Fix typo
containi -> contain
Recently, I got those below errors on logs:
```
String formatted incorrectly - parameter 12 (total 12)
L 04/29/2019 - 23:24:40: [AMXX] Displaying debug trace (plugin "miscstats.amxx", version "1.8.3-dev+5154")
L 04/29/2019 - 23:24:40: [AMXX] Run time error 25: parameter error
L 04/29/2019 - 23:24:40: [AMXX] [0] miscstats.sma::checkKills (line 922)
```
It just looks like `"RAMPAGE!!! %s^n%L %d %L (%d hs)"` misses last format rule, which should be `"%L"` pointing to `HS` lang key.
* Lack register_event() on event_enable/disable
Lack register_event() on enable_event and disable_event descriptions
* It shoud be m_iJoiningState not m_iJointState
It shoud be m_iJoiningState not m_iJointState
* Menu buttons stayed english in Plugin's cvar/command menus
That worked, but if there is any better solution to get it working feel free to edit :D
* Changed language parsing to %L
Just a small fix on json_parse return description. I'm sure it was supposed to be `Invalid_JSON` instead of `Invalid_JSONValue`.
Thank you, guys, that's one of my favorites features.
* Additions to hlsdk_const
Added values to hlsdk_const using regamedll_cs and reapi as reference.
* Update cstrike_const.inc
* Prefix constants with CS_ to avoid name collision and for consistency
* Updated Russian ML translations
* Remove [bs] TRANSF_SILENT translation
Since it's totally not related to pull request and it was translated wrong because I looked for Makedonian translation for some reason.
* Updated Russian ML translations
* Fun: Replace ENTINDEX with TypeConversion for consistency
* Fun: Add a class wrapping player's data
* Fun: Make TraceLine a post forward
Reason: as it is it breaks plugins hooking TraceLine because of the original game call is being superceded and other modules can't catch it. It looks like it's this way from the very start fun module has been introduced 13 years ago before. Fakemeta module comes a little later.
* Fun: Clean up code
* Fun: Toggle PlayerPreThink forward on demand
* Fun: Toggle TraceLine forward on demand
* Fun: Add HITZONE* constants for use with set/get_user_hitzone()
* Fun: Refactor a litte the player class
* Fun: Clean up a little more
* Fun: Fix typo in set_user_hitzones from previous commit
* Allow get_players to get the players num only
* used empty brackets instead of zero
* Add get_playersnum_ex stock to amxmisc.inc
* Added missing empty brackets
* Remove brackets from get_players
* Fixed a typo in function description
* Change letters to flags in get_playersnum_ex description
* Add constants for stats functions
* Changed STATS_ to STATSX_ and added 2 more defines
* Added constants for all games
* Add csstats_const.inc and add _MAX_ constats to enum
* Change bodyhits
* Improve messages.inc and message_stocks.inc documentation
* Fix typos
* Fixed typos, added a bunch of @notes and better register_message callback function explanation
* Removed extra argument in set_msg_arg_string
* Creates => Sends
